Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chrome CDP interface connection #2528

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

bgastelo
Copy link
Contributor

These changes should fix the issue with connecting to the chrome runner.

This is the error message:

<js:/home/runner/work/opal/opal/lib/opal/cli_runners/node_modules/chrome-remote-interface/lib/chrome.js>:48:23:in `defaultTarget': No inspectable targets (Exception)
	from <js:/home/runner/work/opal/opal/lib/opal/cli_runners/node_modules/chrome-remote-interface/lib/chrome.js>:193:28:in `_fetchDebuggerURL'
	from node:internal/process/task_queues:95:5:in `processTicksAndRejections'
	from <js:/home/runner/work/opal/opal/lib/opal/cli_runners/node_modules/chrome-remote-interface/lib/chrome.js>:140:25:in `_start'

I based my changes on this comment from the repo: cyrus-and/chrome-remote-interface#445 (comment)

Testing locally, this seems to fix the main issue with CDP. However I am still seeing 2 errors in mspec:

1)
DateTime#to_date maintains the same julian day regardless of local time or zone FAILED
Expected 2456286 == 2456285
to be truthy but was false

2)
Time#wday returns an integer representing the day of the week, 0..6, with Sunday being 0 FAILED
Expected 3 == 4
to be truthy but was false

Maybe it's an issue with my local config?

Thanks,

Brandon

@hmdne
Copy link
Member

hmdne commented Mar 10, 2023

This issue has been recently a problem on our CI, I have confirmed it locally too. Thank you for your hard work on debugging this issue!

Regarding the MSpec errors, those are related to the timezone and we have had many failures like that in the past :(

@hmdne hmdne merged commit 7ba8264 into opal:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants