Bridging: call original constructor for subclasses of level larger than 1 #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an 1 This commit introduces a function `descends_from_bridged_class(klass)` to check if a class or any of its ancestors is a bridged class. During the allocation of a new class, the `descends_from_bridged_class()` function is now used to determine if the new class is a descendant of a bridged class, and if so, it ensures the original JavaScript constructor is correctly called. This enables more accurate and robust handling of class hierarchies involving bridged classes. This problem has manifested in Firefox which didn't capture stacktraces for RuntimeError, but did so for StandardError. This fixes #2540
elia
approved these changes
Jun 5, 2023
Comment on lines
+544
to
+545
| if (klass.$$super) return descends_from_bridged_class(klass.$$super); | ||
| return false; |
There was a problem hiding this comment.
if we invert these two lines we might get tail-call optimization in browsers supporting it (e.g. safari apparently https://webkit.org/blog/6240/ecmascript-6-proper-tail-calls-in-webkit/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a function
descends_from_bridged_class(klass)to check if a class or any of its ancestors is a bridged class. During the allocation of a new class, thedescends_from_bridged_class()function is now used to determine if the new class is a descendant of a bridged class, and if so, it ensures the original JavaScript constructor is correctly called. This enables more accurate and robust handling of class hierarchies involving bridged classes.This problem has manifested in Firefox which didn't capture stacktraces for RuntimeError, but did so for StandardError.
This fixes #2540