iclass: Propagate removal of method from including/prepending modules. #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How does including/prepending a module work in Opal in short - we create a new JavaScript "class" so to speak, called an `iclass`. We copy the methods from a module to that `iclass` and then we inject that `iclass` into the prototype chain. Unfortunately, before this commit, if a method was removed from a module, an iclass wouldn't get updated. This was needed for Flexmock to work under Opal. I believe this will also allow us to make RSpec-Mocks to pass a lot more tests in Opal-RSpec. I am particularly excited about this fix :D This PR has been sponsored by Ribose Inc. ref: plurimath/plurimath#159
elia
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does including/prepending a module work in Opal in short - we create a new JavaScript "class" so to speak, called an
iclass. We copy the methods from a module to thaticlassand then we inject thaticlassinto the prototype chain.Unfortunately, before this commit, if a method was removed from a module, an iclass wouldn't get updated.
This was needed for Flexmock to work under Opal. I believe this will also allow us to make RSpec-Mocks to pass a lot more tests in Opal-RSpec.
I am particularly excited about this fix :D
This PR has been sponsored by Ribose Inc. ref: plurimath/plurimath#159