Improve Array.push() performance when pushing many items
#2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it has a positive effect on the compiler too: |
janbiedermann
force-pushed
the
fix_array_limits
branch
3 times, most recently
from
3016109
to
c7b9e10
Compare
janbiedermann
force-pushed
the
fix_array_limits
branch
from
c7b9e10
to
3281a9a
Compare
elia
changed the title
elia
changed the title
Array.push() performance when pushing many items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a few places
Also initialize doesnt need to splice if length is 0, faster