Hash#rehash - optimize for the common case, no hash collision, avoid calling $slice #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbiedermann
force-pushed
the
hash_rehash_optimization
branch
from
bf22d16
to
e0efabc
Compare
janbiedermann
force-pushed
the
hash_rehash_optimization
branch
from
e0efabc
to
30abcc8
Compare
|
So synthecially measuring this line, this patch improves execution time for this line by ~120% for the common case, but here on github, this patch shows a slight negative overall effect in our benchmarks. What can i say ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.