Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass value in PromiseV2#always just like PromiseV1#always does it #2579

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

janbiedermann
Copy link
Member

@janbiedermann janbiedermann commented Sep 10, 2023

Makes PromiseV2 more compatible with PromiseV1

Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

I added a commit with a couple of tests that pass using PromiseV1 and are partially failing with this code, can you please look into it? I couldn't find any obvious solution 🙏

@janbiedermann
Copy link
Member Author

janbiedermann commented Sep 15, 2023

Things i would still like to do (soon):

  • mark the other private methods private
  • make V2 work in c-Ruby
  • make it isomorphically available in lib, not necessarily required, but would be nice
  • "refactor" for codeclimate

@hmdne
Copy link
Member

hmdne commented Sep 15, 2023

make V2 work in c-Ruby

Well... I'm afraid we would need to use V1 not V2, but both are mostly compatible (we are finding incompatibilities just now).

make it isomorphically available in lib

Creating an isomorphic core is a great idea. But - I'd say, we would want to rename it to Opal::Promise perhaps.

@hmdne hmdne merged commit e5385d5 into opal:master Sep 21, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants