Unexpected return/break should raise LocalJumpError #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmdne
reviewed
Sep 24, 2023
takaram
force-pushed
the
local_jump_error
branch
from
59e286e
to
5ee9d9a
Compare
elia
approved these changes
Sep 28, 2023
|
This PR caused a significant failure at some codebase I'm working on (namely - https://github.com/plurimath-js/plurimath-js ). I will give more info when I get to debug it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orphaned
Procobjects will throwLocalJumpErroron return or break.See https://ruby-doc.org/3.2.2/Proc.html#class-Proc-label-Orphaned+Proc
Some related bugs are fixed too.