Make Module#define_method
more compatible with CRuby
#2593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several things about
Module#define_method
.define_method
with UnboundMethod accept a blockModule#define_method
with UnboundMethod do not accept a block #2574define_method
tries to convert the first argument to String usingto_str
Module#remove_method
andModule#undef_method
share the same logicdefine_method
ignores the block when the second argument is passeddefine_method
raises TypeError if the passed method's owner is the receiver's child or unrelated class