Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign correct values to underscore parameters #2606

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

takaram
Copy link
Member

@takaram takaram commented Nov 3, 2023

Closes #2312

When there are parameters with the same name on method definition
(allowed only when the name starts with "_"), values are not correctly
assigned to the parameters.

Closes opal#2312
@takaram takaram marked this pull request as draft November 3, 2023 16:14
@takaram takaram marked this pull request as ready for review November 5, 2023 05:05
@hmdne hmdne added this to the v1.8.1 milestone Nov 9, 2023
@hmdne hmdne merged commit 7a79e08 into opal:master Nov 9, 2023
20 checks passed
@takaram takaram deleted the underscore_args branch November 9, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: multiple underscored args with same name not working as expected
2 participants