String#{r,l,}strip: Make them work like in MRI
#2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this patch, we have noticed that NBSP characters are stripped by those methods which is not what MRI does. Those methods now fully follow MRI's behavior. This PR has been sponsored by Ribose Inc.
hmdne
added a commit
to plurimath/plurimath-js
that referenced
this pull request
Nov 12, 2023
- This cherry-picks opal/opal#2612 - In addition, rebase Opal tree to the latest release
elia
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, we have noticed that NBSP characters are stripped by those methods which is not what MRI does.
Those methods now fully follow MRI's behavior.
This fixes #2611
This PR has been sponsored by Ribose Inc.