Initial fork()
support for Node.js
#2635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working, it may happen though, that the parent process exits before the child was able to read its javascript file.
Happens with SystemRunner and its tempfile, which gets deleted when the parent exits. It will fork and then print:
Error: Cannot find module '/tmp/opal-system-runner20240202-905467-v7fj7d.js'
In ruby, such situation will still work, because fork relies on the image in memory. In node, the original javascript file is still required when forking.
That of course is not a issue at all, if the parent process keeps running anyway.
This updates the node requires in nodejs/kernel.rb to use the modern form.