Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional operator indentation #188

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

errt
Copy link
Collaborator

@errt errt commented Jan 23, 2024

As suggested by #187 (comment)

Not sure I like it though, in some places it adds additional indentation to expressions that are already indented a lot.
E.g.:
https://github.com/opalj/opal/blob/40e1c0adaa29e541359d0941b7782d90b1c9e40f/OPAL/br/src/main/scala/org/opalj/br/analyses/AnalysisApplication.scala#L160C1-L166C56

@errt
Copy link
Collaborator Author

errt commented Jan 23, 2024

Note, please treat this as an RFC and comment on whether you are in favor of these changes or not.

@maximilianruesch
Copy link
Collaborator

I am in favor. The code sample above makes sense, if its too indented in some cases there should always be the option to break the first condition to the next line and reduce indentation that way.

@errt errt force-pushed the feature/scalariformRemovalPreparation branch 2 times, most recently from 94dd1d6 to 7f21e49 Compare January 26, 2024 16:41
Base automatically changed from feature/scalariformRemovalPreparation to develop February 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants