Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the way LogViewer retrieve the package version #64

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

Advaith3600
Copy link
Contributor

Used the composer class methods to fetch the version of the package. Read more about it here

Advantage

  • Will show the deployed branch of the package, even while using dev-main, instead of the version in the composer.json file
  • This will help in debugging purposes as well

I have done a small benchmark here and the suggested version seems to work a bit faster than the try catch. Not sure how much will it hold when there are a lot of dependencies in the core application though. Also, in the image, you can see I am using the dev-main branch directly from the composer to see how it looks in those scenarios.

image

@arukompas arukompas merged commit 2bddf5a into opcodesio:main Sep 3, 2022
@arukompas
Copy link
Contributor

Thanks @Advaith3600 , did not know about this! 😄

@Advaith3600 Advaith3600 deleted the version branch September 6, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants