Changed the way LogViewer retrieve the package version #64
+2
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the composer class methods to fetch the version of the package. Read more about it here
Advantage
dev-main
, instead of the version in thecomposer.json
fileI have done a small benchmark here and the suggested version seems to work a bit faster than the try catch. Not sure how much will it hold when there are a lot of dependencies in the core application though. Also, in the image, you can see I am using the
dev-main
branch directly from the composer to see how it looks in those scenarios.