This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(contrib/vagrant): fix vagrant n-node Makefile #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
|
|
||
| run: install restart | ||
| run: install start | ||
|
|
||
| clean: uninstall | ||
| $(call ssh_all,'cd share && for c in $(COMPONENTS); do docker rm -f deis-$$c; done') |
There was a problem hiding this comment.
the cd share here is fluff and is not required. Same goes for full-clean.
There was a problem hiding this comment.
How is it fluff? It's pulling the images before we try starting services, so people aren't sitting around waiting and wondering why deis isn't running.
There was a problem hiding this comment.
the command itself isn't fluff, but cd share is not required for make clean to run. It just removes the container from docker with no reliance on what directory it's running under.
There was a problem hiding this comment.
Ah, gotcha. Yep.
There was a problem hiding this comment.
FWIW those were just copied from the main Makefile, so they should be fixed there as well.
The fleetctl commands weren't valid, and we should disable host checking, as Vagrant nodes will change frequently.
|
@bacongobbler made those changes. |
|
|
bacongobbler
pushed a commit
that referenced
this pull request
Apr 17, 2014
fix(contrib/vagrant): fix vagrant n-node Makefile
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fleetctl commands weren't valid, and we should disable host
checking, as Vagrant nodes will change frequently.