This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(controller): update Django admin fields #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The declarative definition for presenting Build model objects in the Django admin still referenced "sha," which is no longer a field on the Build model. Same for the "version" field on Config. Both of these caused a 500 error when browsing at http://local.deisapp.com:8000/admin/ I also added "created" to Build, Config, and Release and "domain" to Cluster in the admin list display.
|
LGTM. |
|
pinging @gabrtv or @bacongobbler for review |
| @@ -33,7 +33,7 @@ class BuildAdmin(admin.ModelAdmin): | |||
| in the Django admin. | |||
| """ | |||
| date_hierarchy = 'created' | |||
| list_display = ('sha', 'owner', 'app') | |||
| list_display = ('created', 'owner', 'app') | |||
There was a problem hiding this comment.
a Build should also show the image that it created
There was a problem hiding this comment.
owait, this is list_display. Never mind!
|
LGTM |
mboersma
added a commit
that referenced
this pull request
Apr 17, 2014
fix(controller): update Django admin fields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declarative definition for presenting Build model objects
in the Django admin still referenced "sha," which is no longer
a field on the Build model. Same for the "version" field on
Config. Both of these caused a 500 error when browsing at
http://local.deisapp.com:8000/admin/
I also added "created" to Build, Config, and Release and
"domain" to Cluster in the admin list display.