This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(vagrant): use start on make run #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the command hangs if there's nothing to restart, which is the case when booting for the first time. It makes more sense for make run to run make start, and the user should have to specify make restart in order to restart a systemd unit.
|
Makes sense. LGTM. |
|
LGTM. |
bacongobbler
pushed a commit
that referenced
this pull request
Apr 18, 2014
fix(vagrant): use start on make run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the command hangs if there's nothing to restart, which is the case when booting for the first time. It makes more sense for make run to run make start, and the user should have to specify make restart in order to restart a systemd unit.