Implemented GetRecordingEdl for pvr.hts addon. #207
Conversation
|
Making some changes to the backend first... |
|
EDL support is now implemented in tvheadend upstream master. I've added the functionality to the pvr.hts addon. |
|
|
||
| PVR_ERROR CHTSPData::GetEdl(const PVR_RECORDING &recording, PVR_EDL_ENTRY entries[], int *size) | ||
| { | ||
| if (GetProtocol() < 12) return PVR_ERROR_NO_ERROR; |
There was a problem hiding this comment.
this should be PVR_ERROR_NOT_IMPLEMENTED
|
@opdenkamp Changes applied. |
| unsigned int start, end, type; | ||
|
|
||
| if (htsmsg_get_u32(edl, "start", &start) != 0) | ||
| { |
There was a problem hiding this comment.
can you wrap these like this:
if (htsmsg_get_u32(edl, "start", &start) != 0 ||
htsmsg_get_u32(edl, "end", &end) != 0 ||
htsmsg_get_u32(edl, "type", &type) != 0)
{
*size = 0;
return PVR_ERROR_NO_ERROR;
}
also, why do you want to return here, instead of continuing with the next entry?
There was a problem hiding this comment.
Fixed.
why do you want to return here, instead of continuing with the next entry?
Well, initially I figured that if data was missing/broken the rest of the data couldn't be trusted, so basically just "ignore everything". But I've changed my mind on this, so now it will continue in stead...
|
@opdenkamp Fixed from your comments. |
|
okay, please squash it into 1 commit, then it can be pulled |
|
@opdenkamp Squashed and ready! |
Implemented GetRecordingEdl for pvr.hts addon.
The change requires a modified tvheadend server. I've implemented the backend support here:
https://github.com/kendrak24/tvheadend (branch edl_support)