install binaries in lib/

[wsnipex]

pvr addon binaries should go to $prefix/lib/xbmc/addons, like other .so files from normal addons.
addon data still goes to $prefix/share/xbmc/addons

This is needed for packaging, as $prefix/share/xbmc/addons goes in the arch independent package with the standard xbmc packaging scripts and therefore no binaries are allowed.

tested on ubuntu

edit: updated to honor --libdir and --datadir configure options.

[wsnipex]

btw, this also needs a change in the xbmc configure script, because it calls the pvr-addon configure with --prefix="${prefix}/share/xbmc/addons" --includedir="${includedir}" --libdir="${prefix}/share/xbmc/addons" --datadir="${prefix}/share/xbmc/addons"

while it (for) now just should be --prefix="${prefix}"

[fiveisalive]

Yep, +1 from me. I maintain the Fedora/RPM Fusion package for XBMC and such packaging and having the lib / share split is a prerequisite for package acceptance. (Ultimately I plan to package the PVR add-ons as separate binary packages to the main XBMC, so it's good to see that they can be built from a separate source tree).

[opdenkamp]

@wsnipex looking good indeed. could you also create a PR for the xbmc tree that passes the correct options. thanks

@fiveisalive that's the idea behind all of this

[opdenkamp]

hmm merge commit wasn't supposed to be included. please rebase pull request branches next time.
i'll fix up the makefile from xbmc when updating the submodule

[wsnipex]

uhm yeah, I meant to rebase but obviously forgot it :/
sorry about that!

On 08/31/2012 11:46 PM, Lars Op den Kamp wrote:

hmm merge commit wasn't supposed to be included. please rebase pull
request branches next time.
i'll fix up the makefile from xbmc when updating the submodule

—
Reply to this email directly or view it on GitHub
#8 (comment).