Skip to content
This repository has been archived by the owner on Apr 15, 2023. It is now read-only.

pvr: fix seek for recordings #85

Merged
merged 1 commit into from May 7, 2011
Merged

Conversation

FernetMenta
Copy link
Collaborator

there seems to be no need to overwrite total and current playing time for recordings. some other things i was struggling with:

  • GetStartTime is misleading. it actually is the current playing time of a live stream and zero for recordings
  • recording.GetDuration returns minutes. i am not sure if this is used in other places and didn't want to change it

@opdenkamp
Copy link
Owner

yeah noticed it too when I was working at that code last week. can't remember why I didn't change the name (think it was because it's named GetStartTime() in other places in the code too). pretty sure I documented the meaning though.

it's in minutes because the pvr backends usually use minutes for duration instead of seconds. but since xbmc is using seconds everywhere else, I'll change it and convert it to minutes on the pvr interface

opdenkamp pushed a commit that referenced this pull request May 7, 2011
pvr: fix seek for recordings
@opdenkamp opdenkamp merged commit 65af891 into opdenkamp:master May 7, 2011
@opdenkamp
Copy link
Owner

hmm, now that I look into the code, I see that it's mixing up minutes and seconds on the interface too...

@opdenkamp
Copy link
Owner

changed it in 197e35b so it only uses seconds now.

@FernetMenta
Copy link
Collaborator Author

yep, i really did appreciate your comment in the code!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants