Add FineTuning example infra #122
Conversation
Signed-off-by: KfreeZ <kefei.zhang@intel.com> Signed-off-by: Wu, Xiaochang <xiaochang.wu@intel.com>
Signed-off-by: Wu, Xiaochang <xiaochang.wu@intel.com>
|
seems this PR has included code changes of #116, looks like a merge or rebase is needed |
| spec: | ||
| containers: | ||
| - name: opea-finetune | ||
| image: opea-finetune:latest |
There was a problem hiding this comment.
Is the image name correct? Do you mean opea/finetune?
There was a problem hiding this comment.
Thanks for the comment, It's a draft PR now. I will revise the image name.
| name: opea-finetune-entrypoint | ||
| namespace: default | ||
| spec: | ||
| type: NodePort |
There was a problem hiding this comment.
If NodePort is not must, please remove it. NodePort will cause conflict in the CI test machine.
There was a problem hiding this comment.
thanks, I will remove that. do you have a port assignment rule for each new microservice?
There was a problem hiding this comment.
not much rules. It's better to use a same port as mega service but using ClusterIP to avoid hard coded port number. For your reference: https://github.com/opea-project/GenAIInfra/blob/main/manifests/DocSum/xeon/tgi_service.yaml#L17
|
@xwu99 Please add e2e test for this workload. You can follow the format of manifest test script to add three functions: |
thanks, I will follow. |
Description
Infra for adding FineTuning example
Related PRs:
opea-project/GenAIComps#236
opea-project/GenAIExamples#315
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.