cl_document_bcs, fix types (#879)

open-abap · Apr 18, 2024 · 66f8cb6 · 66f8cb6
1 parent 9ecfeb5
commit 66f8cb6
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 19 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -12,10 +12,8 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 5
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
-      with:
-        node-version: '20'
+    - uses: actions/checkout@v4
+    - uses: actions/setup-node@v4
     - run: npm install
     - run: npm test
   integration:
@@ -25,10 +23,8 @@ jobs:
     env:
       HTTP_BIN_HOST: http://localhost:8080
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
-      with:
-        node-version: '20'
+    - uses: actions/checkout@v4
+    - uses: actions/setup-node@v4
     - run: docker run -d -p8080:80 kennethreitz/httpbin
     - run: npm install
     - run: npm run integration
@@ -37,15 +33,13 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 10
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
-      with:
-        node-version: '20'
+    - uses: actions/checkout@v4
+    - uses: actions/setup-node@v4
     - name: Performance After
       run: |
         npm install && npm run performance
         cp results.json results_after.json
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
         ref: main
         path: before
@@ -71,7 +65,7 @@ jobs:
 
     - name: Find Comment
       if: steps.findPr.outputs.pr != ''
-      uses: peter-evans/find-comment@v2
+      uses: peter-evans/find-comment@v3
       id: fc
       with:
         issue-number: '${{steps.findPr.outputs.pr}}'
@@ -81,7 +75,7 @@ jobs:
 
     - name: Create comment
       if: steps.findPr.outputs.pr != ''
-      uses: peter-evans/create-or-update-comment@v3
+      uses: peter-evans/create-or-update-comment@v4
       id: create-comment
       with:
         issue-number: '${{steps.findPr.outputs.pr}}'

diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
   },
   "license": "MIT",
   "dependencies": {
-    "@abaplint/cli": "^2.106.5",
+    "@abaplint/cli": "^2.106.7",
     "@abaplint/runtime": "^2.8.24",
     "@abaplint/database-sqlite": "^2.8.0",
     "@abaplint/transpiler-cli": "^2.8.24"

diff --git a/src/bcs/cl_document_bcs.clas.abap b/src/bcs/cl_document_bcs.clas.abap
@@ -4,7 +4,7 @@ CLASS cl_document_bcs DEFINITION PUBLIC.
 
     CLASS-METHODS create_document
       IMPORTING
-        i_type    TYPE string
+        i_type    TYPE clike
         i_subject TYPE clike
         i_text    TYPE any OPTIONAL
         i_length  TYPE i OPTIONAL
@@ -15,8 +15,8 @@ CLASS cl_document_bcs DEFINITION PUBLIC.
 
     METHODS add_attachment
       IMPORTING
-        i_attachment_type    TYPE string
-        i_attachment_subject TYPE string
+        i_attachment_type    TYPE clike
+        i_attachment_subject TYPE clike
         i_attachment_size    TYPE i OPTIONAL
         i_att_content_text   TYPE any OPTIONAL
         i_att_content_hex    TYPE any OPTIONAL