Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds certificates #135

Merged
merged 3 commits into from
Jun 20, 2024
Merged

feat: adds certificates #135

merged 3 commits into from
Jun 20, 2024

Conversation

rsdmike
Copy link
Member

@rsdmike rsdmike commented May 8, 2024

No description provided.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 36.05%. Comparing base (f8ee20a) to head (c1ebc23).

Files Patch % Lines
internal/usecase/devices/wsman/message.go 0.00% 31 Missing ⚠️
internal/usecase/devices/certificates.go 97.18% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
+ Coverage   35.03%   36.05%   +1.02%     
==========================================
  Files          52       53       +1     
  Lines        3839     3949     +110     
==========================================
+ Hits         1345     1424      +79     
- Misses       2406     2436      +30     
- Partials       88       89       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjbrache rjbrache force-pushed the certificates branch 12 times, most recently from e625ad4 to 85d1c3f Compare June 12, 2024 23:38
Co-authored-by: madhavilosetty-intel <madhavilosetty-intel@users.noreply.github.com>
@rjbrache rjbrache marked this pull request as ready for review June 13, 2024 16:30
@madhavilosetty-intel madhavilosetty-intel merged commit 7e7bfd8 into main Jun 20, 2024
21 of 22 checks passed
@madhavilosetty-intel madhavilosetty-intel deleted the certificates branch June 20, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants