Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiles): self-signed cert for tls profile update #754

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Conversation

intelkrishi
Copy link
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #754 (a629981) into main (6f82bf1) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #754      +/-   ##
==========================================
+ Coverage   82.08%   82.20%   +0.12%     
==========================================
  Files          92       92              
  Lines        3840     3855      +15     
  Branches      624      626       +2     
==========================================
+ Hits         3152     3169      +17     
+ Misses        687      685       -2     
  Partials        1        1              
Impacted Files Coverage Δ
src/routes/admin/profiles/edit.ts 85.71% <100.00%> (+3.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rsdmike
rsdmike previously approved these changes Nov 14, 2022
auto-merge was automatically disabled November 18, 2022 17:29

Rebase failed

@rsdmike rsdmike merged commit 8544500 into main Nov 18, 2022
@rsdmike rsdmike deleted the rps_cert_bug branch November 18, 2022 17:29
@matt-primrose matt-primrose linked an issue Nov 28, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS Config/self signed cert not creating on edit of AMT profile
4 participants