Generalise SwaggerUI plug config supplementing for Phoenix app #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears there's a problem with the CI checks. This issue seems to be associated with the runtime of the Endpoint and its corresponding configuration. Investigating... |
|
@zorbash, apologies for reaching out directly, but I noticed you managed the last release of this project. Could you assist with reviewing this PR, or direct me to the appropriate person to contact? If this PR needs further updates, expansions, or adjustments to the code, tests, or documentation, please let me know, and I'll make the necessary changes. |
zorbash
reviewed
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #546.
The previous implementation of the SwaggerUI plug's configuration supplementing function for the Phoenix app was limited. It only applied to
oauth2_redirect_urland joined thepathonly with the Endpoint URL. This approach was inaccurate if apathwas already present in the Endpoint URL configuration.This PR enhances the configuration supplementing functionality. It introduces the ability to join desired paths with
:endpoint_urland:endpoint_path. This flexibility is provided for all configuration values that adhere to the respective structure.