Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Edit embed config to allow overriding the label on the search box #1534

Closed
jwalgran opened this issue Nov 29, 2021 · 2 comments
Closed

Edit embed config to allow overriding the label on the search box #1534

jwalgran opened this issue Nov 29, 2021 · 2 comments
Assignees

Comments

@jwalgran
Copy link
Contributor

jwalgran commented Nov 29, 2021

Overview

Edit embed config to allow overriding the label on the search box

Depend on model updates in #1533

Describe the solution you'd like

  • Update API to allow passing text_search_label when updating EmbedConfig
    • Normalize empty string to null
  • Update embedded map UI to add a "Text search label"
    - Include a subsection for 'Custom search text label' under the Fields section of the embed config
    - Info text should describe the use of the custom search text and that it's available when fields are marked searchable
    - Disable the custom search label when no fields are searchable
    - Set the default value to the default search text
    - onBlur, if the text search label is blank, replace it with the default text
    - If at any time no fields are marked searchable, the custom search box is should be reset to the default text and disabled
  • Update search sidebar UI to show custom label which is set on the EmbedConfig
@emilyhu0106
Copy link
Contributor

@jwalgran Just for clarification - do we need to update the placeholder for the input here accordingly? image.png

@jwalgran
Copy link
Contributor Author

Yes. We do want to change the placeholder text.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants