This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseycesari
suggested changes
Jan 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small things, but otherwise working well.
lederer
reviewed
Jan 24, 2022
lederer
reviewed
Jan 24, 2022
lederer
reviewed
Jan 24, 2022
Thanks for the feedback! I've made the suggested style changes and it's ready for another look. |
lederer
reviewed
Jan 25, 2022
lederer
reviewed
Jan 25, 2022
lederer
suggested changes
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements. Thank you. Added a couple more and then that should do it.
lederer
approved these changes
Jan 25, 2022
caseycesari
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Edit embed field config to allow marking a field as searchable and add model and API support for persistence.
TaiWilkin
force-pushed
the
tw/update-embed-config-model
branch
from
January 26, 2022 16:12
004e77a
to
16aa947
Compare
Thank you for all the great feedback! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Edit embed field config to allow marking a field as searchable and
add model and API support for persistence.
Connects #1533
Demo
Notes
Adding the checkbox to the right of the fields input caused the draggability buttons to wrap to the next row on certain screen sizes. I adjusted the layout / breakpoints to move the embed code box above the fields list on smaller screen sizes.
The new text_search_label field has been added to the embed config model, but hasn't yet been added to the embed config page. See #1534 for next steps.
Testing Instructions
./scripts/manage migrate
./scripts/server
Embed Deluxe / Custom Embed
and save.oar-extra-fields.csv
vagrant
, run (with the appropriate list-id):Checklist
fixup!
commits have been squashed