Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Remove Sample Data and Update Registration Text #1291

Merged
merged 2 commits into from Mar 30, 2021

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Mar 23, 2021

Overview

  • Significant numbers of users are not deleting the first row of sample
    data from the OAR Contributor templates, meaning we end up with
    "Example facility" as an entry in the tool. Deletes the first row of
    sample data from the OAR contributor templates.
  • The text on the "Register" page of the site is confusing, now that
    users have to create an account & log in before downloading searches.
    Updating this text resolves the issue.

Connects #1267 and #725

Demo

Screen Shot 2021-03-23 at 2 25 04 PM

Testing Instructions

  • Run ./scripts/server in vagrant
  • Navigate to Registration
    • Confirm the text says "Thank you for your interest in the OAR. In order to download data from, or contribute to, the OAR please first set up a free account:"
  • Sign in as a contributor. Navigate to Contribute. Download each of the four list templates.
    • The templates should contain the headers as previously
    • The templates should not contain example data

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Significant numbers of users are not deleting the first row of sample
data from the OAR Contributor templates, meaning we end up with
"Example facility" as an entry in the tool. Deletes the first row of
sample data from the OAR contributor templates.
Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Thanks.

@@ -33,10 +33,6 @@ const ContributeHeader = memo(() => (
Do not change the column heading titles in the first
row.
</li>
<li className="helper-list__item">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran Mar 24, 2021
The text on the "Register" page of the site is confusing, now that
users have to create an account & log in before downloading searches.
Updating this text resolves the issue.
@TaiWilkin TaiWilkin merged commit 162a9d9 into develop Mar 30, 2021
@TaiWilkin TaiWilkin deleted the tw/remove-sample-data branch March 30, 2021 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants