Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Update logo and copy #1449

Merged
merged 3 commits into from Aug 10, 2021
Merged

Update logo and copy #1449

merged 3 commits into from Aug 10, 2021

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Aug 4, 2021

Overview

Updates the logo, powered-by footer image, newsletter signup copy, and facility status report copy.

Connects #1432, #1438, #1439

Demo

Screen Shot 2021-08-04 at 3 16 42 PM

Screen Shot 2021-08-04 at 3 19 40 PM

Screen Shot 2021-08-04 at 3 20 12 PM

Screen Shot 2021-08-04 at 3 20 49 PM

Testing Instructions

  • Run ./scripts/server
  • Navigate to embedded map (replace the contributor with a contributor with an embed config) and view the footer image.
  • Navigate to the full website and view the logo in the header
  • Navigate to a facility and click 'report facility as closed'. Check the text.
  • Log out and select 'register'. Check the newsletter signup text.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I a couple issues, one of which is a 🤦 from me, recommending the PNG version of the logo rather than the SVG.

Screen Shot 2021-08-05 at 7 49 13 AM

  • The mailing list checkbox is no longer on the same line as the text now that the text is longer.

Screen Shot 2021-08-05 at 7 51 01 AM

<img src={logo} className="App-logo" alt="logo" />
<img
src={logo}
style={{ height: '60px' }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new image has white space at the top and bottom, causing a 40px high image to appear smaller. Increasing the size corrects this. (Adjusting the CSS didn't correct the issue, despite clearing the cache/etc., but using styles directly worked.)

onChange={onChange}
style={controlledCheckboxInputStyles.checkbox}
checked={checked}
<FormControlLabel
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MaterialUI FormControlLabel wraps the label and checkbox component, preventing the two elements from splitting onto separate lines at small screen sizes.

@TaiWilkin TaiWilkin requested a review from jwalgran August 5, 2021 18:38
Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -128,7 +128,12 @@ function ReportFacilityStatus({
className={classes.description}
>
Please provide information the OAR team can use to
verify this status change.
verify this status change. Should you need to share or
attach a document or screenshot, please email it to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to force a " " in here between "to" and the email address. Screen Shot 2021-08-06 at 9 00 30 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! Good catch 👍

@jwalgran jwalgran removed their assignment Aug 6, 2021
Replaces the logo and the powered-by footer logo with new images.
Replaces the newsletter signup message to encourage more signups.
Clarifies the instructions for submitting facility status change
reports.
@TaiWilkin TaiWilkin merged commit 7f44052 into develop Aug 10, 2021
@TaiWilkin TaiWilkin deleted the tw/update-logo branch August 10, 2021 20:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants