-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I a couple issues, one of which is a 🤦 from me, recommending the PNG version of the logo rather than the SVG.
- The new main logo is appearing smaller. This may be resolved by using
OpenApparelRegistry_logo_black.svg.zip rather than the PNG. We should also use the SVG version of "powered by"
OAR_PoweredBy_white.svg.zip
- The mailing list checkbox is no longer on the same line as the text now that the text is longer.
<img src={logo} className="App-logo" alt="logo" /> | ||
<img | ||
src={logo} | ||
style={{ height: '60px' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new image has white space at the top and bottom, causing a 40px high image to appear smaller. Increasing the size corrects this. (Adjusting the CSS didn't correct the issue, despite clearing the cache/etc., but using styles
directly worked.)
onChange={onChange} | ||
style={controlledCheckboxInputStyles.checkbox} | ||
checked={checked} | ||
<FormControlLabel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MaterialUI FormControlLabel wraps the label and checkbox component, preventing the two elements from splitting onto separate lines at small screen sizes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -128,7 +128,12 @@ function ReportFacilityStatus({ | |||
className={classes.description} | |||
> | |||
Please provide information the OAR team can use to | |||
verify this status change. | |||
verify this status change. Should you need to share or | |||
attach a document or screenshot, please email it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated! Good catch 👍
Replaces the logo and the powered-by footer logo with new images.
Replaces the newsletter signup message to encourage more signups.
Clarifies the instructions for submitting facility status change reports.
596697f
to
e301fe4
Compare
Overview
Updates the logo, powered-by footer image, newsletter signup copy, and facility status report copy.
Connects #1432, #1438, #1439
Demo
Testing Instructions
./scripts/server
Checklist
fixup!
commits have been squashed