This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix handling of numeric cells in Excel workbooks #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaiWilkin
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
I tested this both with the provided list, and the list Embedded.Map.CSV.Template.-.boohoo.xlsx from the issue. Both lists broke on develop, but were able to be uploaded and processed successfully on this branch.
Thanks for the clear write-up and code comments explaining the fix for this!
With the introduction of number_of_workers we now have a column that can have a numeric value. This presented 2 challenges to the existing Python code. - Excel parsing library returns these as numeric types, but the code was expecting a string. - A value that appears as 130 in the workbook can appear as a float 130.0 after parsing. This commit attempts to fix both of these issues by first manually casing cell values to strings when parsing the workbook, then using an `int(parse(x))` nested cast in the `extract_int_range_value` function to ensure that the decimal portion is removed.
jwalgran
force-pushed
the
bugfix/jvw/handle-numeric-excel-cells
branch
from
0909380
to
f6a0aaa
Compare
|
Thank your for the quick review turnaround. |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
With the introduction of number_of_workers we now have a column that can have a numeric value. This presented 2 challenges to the existing Python code.
This commit attempts to fix both of these issues by first manually casing cell values to strings when parsing the workbook, then using an
int(parse(x))nested cast in theextract_int_range_valuefunction to ensure that the decimal portion is removed.Connects #1638
Testing Instructions
develop, log in as c2@example.com, submitextended-template-test.xlsx. Verify that an error blocks submission.
bugfix/jvw/handle-numeric-excel-cellsand attempt to submit the file again. Verify that it succeeds and that./tools/batch_prcess {is}completes successfully.Checklist
fixup!commits have been squashed