This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix handling of numeric custom cells in Excel #1757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Custom cells can have numeric values. When parsing the sheets, a value
that appears as 130 in the workbook can appear as a float 130.0.
This commit attempts to fix this issue by using an
int(float(x)) nested cast to ensure that the decimal portion is removed.
Note that this will convert all floats to integers when submitted as
custom text. If a contributor would like to submit floats in a custom
text field in the future, we will need to implement that as an
enhancement.
The handling of this was based on the recent fix for number_of_workers.
Connects #1748
Demo
Testing Instructions
NOTE: Custom text indexing can take a minute to run, so wait after adjusting any searchable field.
On
develop
:./scripts/server
Numeric_Custom_List.xlsx
./tools/batch_process {list_id}
On this branch:
./scripts/server
Checklist
fixup!
commits have been squashed