Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Return the contributor admin ID when serializing other locations #950

Merged
merged 1 commit into from Feb 11, 2020

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Feb 7, 2020

Overview

Profile page URLs are constructed using the ID of the admin user for the contributor. We update the serialization of the "Other locations" section of the facility detail page to be consistent with other places in the app where we create profile page links.

Connects #949

Testing Instructions

Setup

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested, works correctly. Nice job adding the tests!

@rajadain rajadain assigned jwalgran and unassigned rajadain Feb 11, 2020
Profile page URLs are constructed using the ID of the admin user for the
contributor. We update the serialization of the "Other locations" section of the
facility detail page to be consistent with other places in the app where we
create profile page links.
@jwalgran jwalgran force-pushed the bugfix/jcw/other-location-links branch from 2f95c59 to 12aa359 Compare February 11, 2020 21:08
@jwalgran
Copy link
Contributor Author

Thanks for the review.

@jwalgran jwalgran merged commit 42ead40 into develop Feb 11, 2020
@jwalgran jwalgran deleted the bugfix/jcw/other-location-links branch February 11, 2020 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants