Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Properly handle deleted contributor when serializing other locations #952

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Feb 11, 2020

NOTE: This is targeted at the release/2.21.1 branch

Overview

This change avoids a crash in the FacilityDetailsSerializer when the contributor
of a match with an alternate location has been deleted.

Connects #949

Notes

This should have been part of #950

Testing Instructions

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested, fixes the bug. Sorry I didn't catch it when reviewing #950.

@rajadain rajadain assigned jwalgran and unassigned rajadain Feb 12, 2020
@jwalgran
Copy link
Contributor Author

Thanks for the review.

Sorry I didn't catch it when reviewing

No problem. Sorry I didn't think of it when I wrote the initial PR. 👍

This change avoids a crash in the FacilityDetailsSerializer when the contributor
of a match with an alternate location has been deleted.
@jwalgran jwalgran force-pushed the bugfix/jcw/handle-deleted-contributor branch from 7d27413 to 2e42f38 Compare February 12, 2020 15:48
@jwalgran jwalgran merged commit 54c4f20 into release/2.21.1 Feb 12, 2020
@jwalgran jwalgran deleted the bugfix/jcw/handle-deleted-contributor branch February 12, 2020 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants