Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add a contributors with active lists report #990

Merged
merged 1 commit into from Mar 13, 2020

Conversation

TaiWilkin
Copy link
Contributor

Overview

The exiting /admin/reports/countributors/ report shows all registered
accounts. We need a version that only lists those contributor accounts
that have submitted facilities.

This adds a contributors-with-active-facilities report.
It has the same output schema as the contributors report and
uses the same filter criteria as the /api/contributors endpoint.

Connects #988

Demo

Screen Shot 2020-03-13 at 1 51 30 PM

Testing Instructions

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@TaiWilkin TaiWilkin requested a review from jwalgran March 13, 2020 17:53
@jwalgran jwalgran self-assigned this Mar 13, 2020
Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the report, downloaded it, and compared it with the response from http://localhost:6543/api/contributors. Perfect match.

Screen Shot 2020-03-13 at 10 59 31 AM

@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran Mar 13, 2020
The exiting /admin/reports/countributors/ report shows all registered
accounts. We need a version that only lists those contributor accounts
that have submitted facilities.

This adds a contributors-with-active-facilities report.
It has the same output schema as the contributors report and
uses the same filter criteria as the /api/contributors endpoint.
@TaiWilkin TaiWilkin merged commit 67f395f into develop Mar 13, 2020
@TaiWilkin TaiWilkin deleted the tw/active-contrib-report branch March 13, 2020 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants