This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix the contributors with active facilities report #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first draft of the report had two issues that we only realized after running the report with production data: - Lines were duplicated for contributor with multiple lists. - If any of the items on a contributor's list were in an error state, the contributor did not appear. This commit attempts to address those issues by: - Using an `IN` clause with a subquery rather than joining the contributor table to the source table. - Inverting the error status filter condition to allow a contributor if any sources are in a non-error status.
jwalgran
force-pushed
the
bugfix/jcw/update-contrib-with-active-report
branch
from
96ebd4b
to
9490b9c
Compare
|
Looking at this now |
|
I ran the query for this on the production data and manually compared it to the response from |
TaiWilkin
approved these changes
Mar 13, 2020
|
This looks great. Thanks for catching this! |
|
Thanks for the review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The first draft of the report had two issues that we only realized after running
the report with production data:
contributor did not appear.
This commit attempts to address those issues by:
INclause with a subquery rather than joining the contributor tableto the source table.
sources are in a non-error status.
Connects #988
Testing Instructions
NOTE I was was unable to reproduce the problem with contributors not appearing using development data at the time of opening this PR but, in the interest of getting a report out ASAP I have not waited until I could come up with a test situation.
developbranchc2@example.comgood.csv
c1@example.comc1@example.comc2@example.comonly appears once.Checklist
fixup!commits have been squashed