Allow individual masterchefs to update in case only one needs to be u…

…pdated.
open-bakery · May 3, 2023 · 68e6cc9 · 68e6cc9
1 parent 329ee7e
commit 68e6cc9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/src/AMasterchefBase.sol b/src/AMasterchefBase.sol
@@ -126,7 +126,6 @@ abstract contract AMasterchefBase is Ownable {
   /// @notice Adds rewards to the pool and updates the reward rate.
   /// Must add and evenly distribute rewards through the rewardsDuration.
   function updateRewards(uint256 amount) external virtual onlyOwner {
-    require(amount != 0, 'Masterchef: Nothing to update');
     require(totalAllocPoint != 0, 'Masterchef: Must initiate a pool before updating rewards');
     IERC20(REWARD_TOKEN).safeTransferFrom(msg.sender, address(this), amount);
 

diff --git a/src/FeeSplitter.sol b/src/FeeSplitter.sol
@@ -128,8 +128,12 @@ contract FeeSplitter is Ownable {
     pendingBucketTokenIn = 0;
     remainingBucketsTokenIn = 0;
 
-    Masterchef(MASTERCHEF_0).updateRewards(mc0TokenIn);
-    Masterchef(MASTERCHEF_1).updateRewards(mc1TokenIn);
+    if (mc0TokenIn != 0) {
+      Masterchef(MASTERCHEF_0).updateRewards(mc0TokenIn);
+    }
+    if (mc1TokenIn != 0) {
+      Masterchef(MASTERCHEF_1).updateRewards(mc1TokenIn);
+    }
 
     emit UpdateFees(msg.sender, totalExchangedIn, mc0TokenIn, mc1TokenIn);
   }

diff --git a/test/Audit.t.sol b/test/Audit.t.sol
@@ -78,7 +78,6 @@ contract AuditTest is ABaseExit10Test {
       skip(1 days);
 
       // Call updateFees with 0 amount
-      vm.expectRevert(bytes('Masterchef: Nothing to update'));
       FeeSplitter(feeSplitter).updateFees(0);
 
       console.log('MC0 RewardRate:', masterchef0.rewardRate());