Audit L8: Possible loss of funds with price limited swaps through Dep…

…ositHelper
open-bakery · May 8, 2023 · 87257c0 · 87257c0
1 parent 3578b12
commit 87257c0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/DepositHelper.sol b/src/DepositHelper.sol
@@ -83,10 +83,10 @@ contract DepositHelper {
       amountOut = IUniswapV3Router(UNISWAP_V3_ROUTER).exactInputSingle(_swapParams);
 
       if (_swapParams.tokenIn == TOKEN_0) {
-        _initialAmount0 -= _swapParams.amountIn;
+        _initialAmount0 = IERC20(TOKEN_0).balanceOf(address(this));
         _initialAmount1 += amountOut;
       } else {
-        _initialAmount1 -= _swapParams.amountIn;
+        _initialAmount1 = IERC20(TOKEN_1).balanceOf(address(this));
         _initialAmount0 += amountOut;
       }
     }

diff --git a/test/DepositHelper.t.sol b/test/DepositHelper.t.sol
@@ -208,6 +208,7 @@ contract DepositHelperTest is ABaseExit10Test {
     uint256 usdcLeft = ERC20(usdc).balanceOf(address(depositHelper));
     console.log('Only', swapAmount0 - usdcLeft, 'USDC has been swapped and used to mint bonds');
     console.log('USDC Left into DepositHelper:', usdcLeft);
+    assertEq(usdcLeft, 0, 'Check usdcLeft == 0');
   }
 
   function _getSwapParams(