Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to support newer conda-build versions #142

Merged
merged 5 commits into from
Sep 12, 2022

Conversation

cdeepali
Copy link
Contributor

@cdeepali cdeepali commented Sep 9, 2022

Checklist before submitting

Description

With conda-build versions higher than 3.21.7, we are seeing the issue described in #117 with default value of config.croot.
Thus setting config.croot to blank here, to avoid the error and thus support newer versions of conda-build.

I have retained pins in Dockerfiles, to ensure that the build is done against same version of conda-build across the board.

Review process to land

  1. All tests and other checks must succeed.
  2. At least one maintainer must review and approve.
  3. If any maintainer requests changes, they must be addressed.

@codecov-commenter
Copy link

Codecov Report

Merging #142 (ab71b26) into main (d3a0954) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   96.16%   96.16%           
=======================================
  Files          23       23           
  Lines        2109     2110    +1     
=======================================
+ Hits         2028     2029    +1     
  Misses         81       81           
Flag Coverage Δ
unittests 96.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
open_ce/conda_utils.py 98.88% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cdeepali cdeepali merged commit c757f2c into open-ce:main Sep 12, 2022
@cdeepali cdeepali deleted the dc-fixforworkdir branch September 12, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants