Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BuildTree class #38

Merged
merged 5 commits into from
Sep 28, 2020
Merged

Conversation

bnemanich
Copy link
Member

@bnemanich bnemanich commented Sep 24, 2020

This PR creates 2 new classes.

  1. BuildCommand
    Holds all of the information needed to perform a single run of build_feedstock. Provides two helpful methods:
    feedstock_args: This will return a list of strings that can be passed to build_feedstock to perform a build.
    name: This will print out a name for the command, combining the recipe name with the python versions and build_type.

  2. BuildTree:
    Container for a list of BuildCommands.
    The constructor will clone all of the feedstocks specified in the provided environment files and create a list of BuildCommands using the dependency information found in the recipe's meta.yaml files.
    Iterating over the BuildTree will ensure that all dependent packages appear before any packages relying on them.
    Indexing into the BuildCommand will correlate to the indices provided in a BuildCommand's build_command_dependencies field.

@bnemanich bnemanich marked this pull request as ready for review September 25, 2020 18:51
@bnemanich bnemanich changed the title Initial draft of BuildTree class Add BuildTree class Sep 25, 2020
Copy link
Member

@bethune-bryant bethune-bryant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that small issue, it looks good to me.

open-ce/build_env.py Outdated Show resolved Hide resolved
@bnemanich bnemanich merged commit 3edcf04 into open-ce:master Sep 28, 2020
@bnemanich bnemanich deleted the create_build_tree_class branch September 28, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants