Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitespace Truncates original command by one character #194

Closed
Jonathan002 opened this issue Aug 16, 2019 · 1 comment
Closed

Whitespace Truncates original command by one character #194

Jonathan002 opened this issue Aug 16, 2019 · 1 comment

Comments

@Jonathan002
Copy link

Jonathan002 commented Aug 16, 2019

Concurrently v4.1.1

I've noticed that adding whitespace removes the last character of the command inputed.

e.g.

// Command ran is ngin instead of nginx
concurrently \"nginx \"
[0] /bin/sh: 1: ngin: not found
[1]  exited with code 0
[0] ngin exited with code 127

Although it works perfectly fine when no space is added.

// Expected behavior
concurrently \"nginx\"
[0] nginx: [emerg] invalid number of arguments in "user" directive in /data/etc/nginx/nginx.conf:2
[0] nginx exited with code 1

I've also noticed an issue similar to this here: https://github.com/kimmobrunfeldt/concurrently/issues/118

Just wanted to report this. Thanks

@gustavohenke
Copy link
Member

Thanks for the report.
Yeah the quote stripping logic didn't handle impaired quotes -- I pushed a fix for it.

If you add a trailing space, my fix will not make your command line run though: concurrently will receive 2 commands, \"nginx and \". That's because you're wrapping the quotes when you don't need to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants