Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit code null when --kill-others specified #91

Closed
kentcdodds opened this issue Feb 18, 2017 · 2 comments
Closed

exit code null when --kill-others specified #91

kentcdodds opened this issue Feb 18, 2017 · 2 comments

Comments

@kentcdodds
Copy link
Contributor

This one's a little odd, but occasionally (not always), concurrently will receive an exit code of null from one of the processes when I specify --kill-others (like here).

This may be related to #37 and #80 which also indicate an exit code of null. Anyone know how that could happen? And better yet, how to fix it? Here's the code where the exit code comes from.

For now, the workaround is to not use --kill-others, but that's kinda annoying... :-/ I'm happy to submit a fix if someone can give me an idea of how this is even possible.

@Wildhoney
Copy link

Was there a resolution @kentcdodds?

I get the same issue when running a node.js app (even when the node.js app is an empty file) and any other command, such as an echo:

concurrently -k 'node app.js' 'echo "hello world"'

If I replace the node app.js with anything else such as echo then the exit code is 0.

However with node I receive an exit code of null:

[1] echo "..." exited with code 0
--> Sending SIGTERM to other processes..
[0] npm run start exited with code null

@kentcdodds
Copy link
Contributor Author

Well, I opened a PR to fix it and it was merged/released. Maybe what you're seeing is unrelated to what I experienced. You may need to dig deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants