Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to return success or failure of the first child to exit #12

Merged
merged 2 commits into from Nov 15, 2015

Conversation

paulerickson
Copy link
Contributor

Scenario: Run Automated Tests and Dependencies Concurrently

Given I run a webserver and a test runner with --kill-others and --success first,
When the test runner completes
Then I expect concurrently to terminate the webserver
And return the exit code of the test runner, regardless of whether the webserver shut down gracefully


first will stop my test script from returning false positives and make me very happy, but I can't think of a case for last that isn't totally contrived... it just seemed like if I add first, then I should add last too.

@kimmobrunfeldt
Copy link
Contributor

Thanks for the PR, I've thought about this functionality at some point too.

Could you format the code to be consistent with existing code? 4 space indentation etc. After that, this is ready to be merged.

@paulerickson
Copy link
Contributor Author

Sure thing, @kimmobrunfeldt . I think it was just the indentation in main.js (blame vim), but correct me if I missed any other formatting points.

kimmobrunfeldt added a commit that referenced this pull request Nov 15, 2015
Add option to return success or failure of the first child to exit
@kimmobrunfeldt kimmobrunfeldt merged commit ce63634 into open-cli-tools:master Nov 15, 2015
@kimmobrunfeldt
Copy link
Contributor

Now merged and released, sorry that it took so long. https://github.com/kimmobrunfeldt/concurrently/releases/tag/1.0.0

@paulerickson
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants