Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prefixLength #189

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Use prefixLength #189

merged 1 commit into from
Jun 25, 2019

Conversation

BrunoBernardino
Copy link

@BrunoBernardino BrunoBernardino commented Jun 5, 2019

The setting was apparently not being sent through via CLI.

Also added a test confirm the behavior and prevent regressions.

Please let me know if there's anything else you'd like me to do here!

The setting was not being sent through.
Also added a test confirm the behavior and prevent regressions.
@coveralls
Copy link

coveralls commented Jun 5, 2019

Pull Request Test Coverage Report for Build 333

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.178%

Totals Coverage Status
Change from base Build 331: 0.0%
Covered Lines: 239
Relevant Lines: 239

💛 - Coveralls

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@gustavohenke gustavohenke merged commit 9529c5e into open-cli-tools:master Jun 25, 2019
@gustavohenke
Copy link
Member

Published as v4.1.1!

@BrunoBernardino
Copy link
Author

Thanks @gustavohenke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants