Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill commands on SIGHUP #195

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Conversation

leo-buneev
Copy link
Contributor

Adds 'SIGHUP' to list of signals that trigger killing of child processes.

@coveralls
Copy link

coveralls commented Aug 22, 2019

Pull Request Test Coverage Report for Build 349

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.178%

Totals Coverage Status
Change from base Build 347: 0.0%
Covered Lines: 239
Relevant Lines: 239

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 348

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.178%

Totals Coverage Status
Change from base Build 347: 0.0%
Covered Lines: 239
Relevant Lines: 239

💛 - Coveralls

@leo-buneev leo-buneev closed this Aug 22, 2019
@leo-buneev leo-buneev reopened this Aug 22, 2019
@leo-buneev
Copy link
Contributor Author

During testing I've discovered that my particular issue was not caused by this.
However, I still think that adding SIGHUP to list of signlas is useful - up to you if you want to merge it.

@gustavohenke gustavohenke self-requested a review August 25, 2019 09:00
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During testing I've discovered that my particular issue was not caused by this.

Fair enough.
I agree that this is useful nonetheless.

@gustavohenke gustavohenke merged commit b140ef1 into open-cli-tools:master Aug 25, 2019
@gustavohenke gustavohenke changed the title Fix #193 Kill commands on SIGHUP Aug 25, 2019
@gustavohenke
Copy link
Member

Landed on v5.0.0!

@cben
Copy link

cben commented Apr 7, 2020

I added logging to tree-kill and it seems it doesn't know what's SIGHUP?

[2] yarn insights-proxy exited with code SIGINT
--> Sending SIGTERM to other processes..
[1] mockdata/mockserver.py exited with code 1
--> Sending SIGTERM to other processes..
tree-kill: sending SIGINT to process 19857
tree-kill: sending SIGINT to process 19856
tree-kill: sending SIGINT to process 19855
tree-kill: sending undefined to process 19856
~/u/uhc-portal [130] $ tree-kill: sending undefined to process 19855
tree-kill: sending undefined to process 19855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants