Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Node.js v12 & add support for Node.js v18 #342

Merged
merged 9 commits into from
Nov 26, 2022
Merged

Drop support for Node.js v12 & add support for Node.js v18 #342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5e427a5
Drop support for Node.js v12 & add support for Node.js v18
paescuj Aug 3, 2022
7ed2a49
Minor dependencies updates & update lint-staged to v13
paescuj Aug 3, 2022
2c120ac
Replace depreacted 'rmdirSync' & use top-level-await in sleep fixture
paescuj Aug 11, 2022
1784e47
Downgrade @types/node to lowest supported Node.js version (14)
paescuj Aug 12, 2022
08a1aab
Update package-lock.json
paescuj Nov 13, 2022
9a8efda
Clean-up tsconfig
paescuj Nov 26, 2022
6bb5443
Simplify "engines" definition
paescuj Nov 26, 2022
c543a95
Test against Node.js v19 (current)
paescuj Nov 26, 2022
0460abd
Update lint-staged
paescuj Nov 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ jobs:
fail-fast: false
matrix:
node:
- 12
- 14
- 16
- 17
- 18
- 19
os:
- name: Ubuntu
version: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion bin/concurrently.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ beforeAll(async () => {
afterAll(() => {
// Remove the temporary directory where 'concurrently' was stored
if (tmpDir) {
fs.rmdirSync(tmpDir, { recursive: true });
fs.rmSync(tmpDir, { recursive: true });
}
});

Expand Down
12 changes: 4 additions & 8 deletions bin/fixtures/sleep.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,10 @@

/* eslint-disable no-console */

async function run(s) {
await new Promise((resolve) => setTimeout(resolve, s * 1000));
}

const s = process.argv[2];
if (!s || isNaN(s) || process.argv.length > 3) {
const seconds = process.argv[2];
if (!seconds || isNaN(seconds) || process.argv.length > 3) {
// Mimic behavior from native 'sleep' command
console.error(`usage: sleep seconds`);
console.error('usage: sleep seconds');
process.exit(1);
}
run(s);
await new Promise((resolve) => setTimeout(resolve, seconds * 1000));