Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shorthand conc #358

Merged
merged 4 commits into from Aug 22, 2022
Merged

Conversation

kecrily
Copy link
Contributor

@kecrily kecrily commented Aug 17, 2022

concurrently is too long, which makes it unfriendly to non-English users and tiresome to type, which discourages potential users.

It simplifies the multiple-entry command &&, but not in the command line name. Let's add a shorthand to simplify it. Use conc shorthand

@coveralls
Copy link

coveralls commented Aug 17, 2022

Coverage Status

Coverage remained the same at 100.0% when pulling 6e02952 on kecrily:feat/shorthand into 71e1c56 on open-cli-tools:main.

@paescuj
Copy link
Collaborator

paescuj commented Aug 17, 2022

Thank you @kecrily for your contribution! I like this idea! 👍

ToDo's:

  • Update the docs
  • Verify all things are working with the alias (help output, etc.)

@paescuj
Copy link
Collaborator

paescuj commented Aug 17, 2022

@kecrily Would you like to work on the ToDo's mentioned above?

@kecrily
Copy link
Contributor Author

kecrily commented Aug 18, 2022

I have updated the documentation and verified it.

@paescuj
Copy link
Collaborator

paescuj commented Aug 19, 2022

@gustavohenke Do you think we need to adjust something else? Also before merging this we should make sure the chosen alias fits well in the long term. For example, cncr (official abbreviation of "concurrent") would be another possibility, although I think conc is easier to remember. Any other ideas?

Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on limited computer time for a couple more weeks, so one thing I'd like to know is whether any alias will conflict with other popular/native OS tools.

From what I managed to test, it doesn't seem like a non-dev Mac has either conc or cncr.
It'd be good to know if an alias would conflict with tools on Windows or Linux too.

Also fwiw, concurrently used to have a concurrent alias back before v4:
7383eca

I'll let you decide this one @paescuj 🙂

@paescuj
Copy link
Collaborator

paescuj commented Aug 22, 2022

Thanks for your feedback @gustavohenke!

Let's go with conc as it clearly shows that it belongs to concurrently.

I'm on limited computer time for a couple more weeks, so one thing I'd like to know is whether any alias will conflict with other popular/native OS tools.

That's a good point!
conc doesn't seem to conflict with other tools neither on Linux (checked with Ubuntu) nor on Windows (checked in PS, cmd & Google) and macOS (terminal, Homebrew). Also couldn't find another module on NPM which provides a command named conc.

Also fwiw, concurrently used to have a concurrent alias back before v4: 7383eca

Interesting 😄

@paescuj paescuj merged commit e469c04 into open-cli-tools:main Aug 22, 2022
@paescuj
Copy link
Collaborator

paescuj commented Aug 22, 2022

@gustavohenke Could you publish a new version as soon as you have time?

@gustavohenke
Copy link
Member

Published as v7.4.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants