Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch spawn-default-shell with spawn-command #89

Merged
merged 1 commit into from Feb 12, 2017

Conversation

kentcdodds
Copy link
Contributor

Due to kimmobrunfeldt/spawn-default-shell#8

Tests pass locally on my Mac. Should probably test this with windows users.

@kentcdodds
Copy link
Contributor Author

This may actually solve #69 and I just noticed #61! Looks like this was a pre-existing issue!

@kentcdodds
Copy link
Contributor Author

Using my fork fixes my issue. And it looks like the windows build passes.

@gustavohenke
Copy link
Member

What a shame that Kimmo won't be eating his own dog food anymore :(

@kentcdodds kentcdodds deleted the pr/use-spawn-command branch February 12, 2017 16:21
@gustavohenke
Copy link
Member

Published v3.3.0!

@kentcdodds
Copy link
Contributor Author

Awesome! Thanks!

gkalpak referenced this pull request in gkalpak/angular Feb 15, 2017
The error in 3.2.0 (that made us roll back to 3.1.0) has been fixed in 3.3.0
(see kimmobrunfeldt/concurrently#89).
gkalpak referenced this pull request in gkalpak/angular Feb 15, 2017
The regression in `concurrently` v3.2.0 (which made us roll back to v3.1.0
in angular#14378) has been fixed in v3.3.0 (see kimmobrunfeldt/concurrently#89).
gkalpak referenced this pull request in gkalpak/angular Feb 15, 2017
The regression in `concurrently` v3.2.0 (which made us roll back to v3.1.0
in angular#14378) has been fixed in v3.3.0 (see kimmobrunfeldt/concurrently#89).
gkalpak referenced this pull request in gkalpak/angular May 2, 2017
The regression in `concurrently` v3.2.0 (which made us roll back to v3.1.0
in angular#14378) has been fixed in v3.3.0 (see kimmobrunfeldt/concurrently#89).
gkalpak referenced this pull request in gkalpak/angular May 2, 2017
The regression in `concurrently` v3.2.0 (which made us roll back to v3.1.0
in angular#14378) has been fixed in v3.3.0 (see kimmobrunfeldt/concurrently#89).
matsko referenced this pull request in angular/angular May 3, 2017
The regression in `concurrently` v3.2.0 (which made us roll back to v3.1.0
in #14378) has been fixed in v3.3.0 (see kimmobrunfeldt/concurrently#89).
matsko referenced this pull request in angular/angular May 4, 2017
The regression in `concurrently` v3.2.0 (which made us roll back to v3.1.0
in #14378) has been fixed in v3.3.0 (see kimmobrunfeldt/concurrently#89).
asnowwolf referenced this pull request in asnowwolf/angular Aug 11, 2017
The regression in `concurrently` v3.2.0 (which made us roll back to v3.1.0
in angular#14378) has been fixed in v3.3.0 (see kimmobrunfeldt/concurrently#89).
juleskremer referenced this pull request in juleskremer/angular Aug 28, 2017
The regression in `concurrently` v3.2.0 (which made us roll back to v3.1.0
in angular#14378) has been fixed in v3.3.0 (see kimmobrunfeldt/concurrently#89).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants