Default --prefix to "name" when --names is set #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consolidate readline test code in test/utils.js - Move responsibility for DEBUG_TESTS to run() - Remove unused cwd option
src/main.js
Outdated
| @@ -81,7 +83,7 @@ function parseArgs() { | |||
| '-p, --prefix <prefix>', | |||
| 'prefix used in logging for each process.\n' + | |||
| 'Possible values: index, pid, time, command, name, none, or a template. Default: ' + | |||
| config.prefix + '. Example template: "{time}-{pid}"\n' | |||
| 'index. Example template: "{time}-{pid}"\n' | |||
There was a problem hiding this comment.
What if we mentioned both defaults? Too fancy?
gustavohenke
force-pushed
the
default-prefix-name
branch
from
b138bee
to
d061d70
Compare
gustavohenke
approved these changes
Mar 21, 2017
|
@gustavohenke You should release this 🙂 Took me a couple of minutes to realize that the latest release is older than this PR. |
|
@gustavohenke I agree with @jeremejevs. I spent far too much time debugging only to realize that |
|
@RichDonnellan @jeremejevs @enaeseth this was just published as v3.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it confusing that specifying
--nameswithout changing the--prefixcontinues to use a default prefix ofindex. This PR changes the default prefix to benamewhen--namesis set andindexwhen it's not.It also cleans up the test code; since this adds new tests that use
readline, I moved that functionality intotests/utils.js.(cf: kimmobrunfeldt/concurrently#53)