Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

50k limit on ManifestWork not enough to define larger/more complex add-ons #116

Closed
dangorst1066 opened this issue Aug 15, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@dangorst1066
Copy link

dangorst1066 commented Aug 15, 2022

The current add-on framework creates a single ManifestWork that includes all the resources the add on requires to run in the managed clusters.

There is a 50k limit on the size of a ManifestWork resource set here which creates a problem when attempting to deploy more complex add ons , that define many resources. A single CRDs can easily exceed 50k on it's own - for example kustomizations.kustomize.toolkit.fluxcd.io is 60k.

Suggestion is to make the limit on a single ManifestWork configurable (primarily for large CRDs or ConfigMaps) AND update the addon controller to create a ManifestWork per resource (or similar) rather than bundling them all together into a single ManifestWork.

@qiujian16
Copy link
Member

/assign @qiujian16
/kind bug

cc @zhiweiyin318

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

@qiujian16: The label(s) kind/bug cannot be applied, because the repository doesn't have them.

In response to this:

/assign @qiujian16
/kind bug

cc @zhiweiyin318

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiujian16 qiujian16 added the bug Something isn't working label Aug 16, 2022
@qiujian16
Copy link
Member

fixed by #122

@qiujian16
Copy link
Member

/close

@openshift-ci openshift-ci bot closed this as completed Sep 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 27, 2022

@qiujian16: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants