add annotation if addon uses InstallStrategy #236
Conversation
Signed-off-by: haoqing0110 <qhao@redhat.com>
|
/assign @qiujian16 |
| @@ -98,6 +108,27 @@ func (c *addonInstallController) sync(ctx context.Context, syncCtx factory.SyncC | |||
| continue | |||
| } | |||
|
|
|||
| cma, err := c.clusterManagementAddonLister.Get(addonName) | |||
There was a problem hiding this comment.
this will be called per mca/cluster event. It might bring a lot of conflict. How about we put this in a controller that reconcile clustermanagementaddon only?
There was a problem hiding this comment.
Yes, that would be a better choice. The current code will have conflicts when the first time adding the annotation, then won't trigger patch annotation action.
There was a problem hiding this comment.
we have another existing controller that is reconciling the clustermanageraddon
haoqing0110
force-pushed
the
br_force-annotation
branch
4 times, most recently
from
aaa3816
to
b127718
Compare
haoqing0110
changed the title
haoqing0110
force-pushed
the
br_force-annotation
branch
from
b127718
to
dfc03e8
Compare
haoqing0110
changed the title
|
/assign @zhiweiyin318 @zhujian7 |
| @@ -38,7 +38,7 @@ | |||
| verbs: ["update", "patch"] | |||
| - apiGroups: ["addon.open-cluster-management.io"] | |||
| resources: ["clustermanagementaddons"] | |||
| verbs: ["get", "list", "watch"] | |||
| verbs: ["get", "list", "watch", "patch"] | |||
There was a problem hiding this comment.
note, we will need users to update the clusterrole when upgrading the library.
There was a problem hiding this comment.
should be reflected in the release notes.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_force-annotation
branch
from
dfc03e8
to
74b6399
Compare
|
LGTM |
|
/lgtm |
openshift-merge-bot
bot
merged commit 41083d1
into
open-cluster-management-io:main
open-cluster-management-io/addon-framework#236 Signed-off-by: Tamal Saha <tamal@appscode.com>
open-cluster-management-io/addon-framework#236 Signed-off-by: Tamal Saha <tamal@appscode.com>
open-cluster-management-io/addon-framework#236 Signed-off-by: Tamal Saha <tamal@appscode.com>
Ref: open-cluster-management-io/ocm#355